test KC upgrade#4411
Draft
aledegano wants to merge 4 commits into
Draft
Conversation
When a modified client is recreated, get_client_service_account_user was called unconditionally on all clients. This caused the script to blow up for clients that do not use the client_credentials OAuth flow and therefore have no service account. Guard the call (and the subsequent role-assignment logic) behind an oauth_flow check, mirroring the pattern already used in the 'client not found' branch. Fixes #4373
Collaborator
|
You can access the deployment of this PR at https://ci-renku-4411.dev.renku.ch |
aledegano
changed the title
…ix_init_kc+upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a modified client is recreated, get_client_service_account_user
was called unconditionally on all clients. This caused the script to
blow up for clients that do not use the client_credentials OAuth flow
and therefore have no service account. Guard the call (and the
subsequent role-assignment logic) behind an oauth_flow check, mirroring
the pattern already used in the 'client not found' branch.
Fixes #4373
/deploy