-
Notifications
You must be signed in to change notification settings - Fork 36
Fixes for compatibility with the latest version of TUnit #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes for compatibility with the latest version of TUnit #216
Conversation
|
any estimates when this can be merged? currently we're stuck with quite old TUnit version, since updating breaks tests? |
…ext metadata access
|
@martynas-m Need someone who maintains this repository 🤷♂️ It seems very inactive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Snapshooter.TUnit integration to be compatible with TUnit version 1.5.6, upgrading from version 0.10.6. The changes adapt to breaking API changes in TUnit's TestContext structure and remove obsolete namespace imports.
- Upgrades all TUnit package dependencies from 0.10.6 to 1.5.6
- Adapts TestContext API usage to the new structure with Metadata property
- Removes unused namespace import that no longer exists in the new TUnit version
- Adds LangVersion specification for consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/Snapshooter.TUnit.Tests/TUnitAssertTests.cs |
Removes obsolete TUnit.Assertions.AssertConditions.Throws namespace import that no longer exists in TUnit 1.5.6 |
test/Snapshooter.TUnit.Tests/Snapshooter.TUnit.Tests.csproj |
Updates TUnit package reference from version 0.10.6 to 1.5.6 |
src/Snapshooter.TUnit/TUnitSnapshotFullNameReader.cs |
Migrates TestContext API calls to use new Metadata.TestDetails structure, updating property paths for ClassType.Name, TestName, and TestMethodArguments |
src/Snapshooter.TUnit/Snapshooter.TUnit.csproj |
Updates TUnit.Assertions and TUnit.Core package references to version 1.5.6, and adds LangVersion>latest</LangVersion> property for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@thomhurst please fix the build/tests than we can merge it |
|
@glucaci All done. Had to Polyfill some compiler attributes that aren't available pre-net core |
No description provided.