Enhance snapshot naming and improve formatting utilities #218
+35
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `MSTestSnapshotFullNameReader.cs` to generate more detailed snapshot names by incorporating parameter strings from data row attributes. - Refactored methods in `AcceptMatchOperator.cs` to be static and improved `GetAcceptFieldValueString` with a switch expression for better readability and culture-invariant numeric formatting. - Added `FormatInvariant` method in `AcceptAssert.cs` to standardize value formatting and improve error message clarity. - Included `using System.Globalization;` in multiple files to support new formatting logic.
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how numeric values are formatted for error messages and snapshot names, ensuring consistent, culture-invariant string representations. It also refactors some helper methods for clarity and static usage, and updates related test helpers.
Numeric value formatting improvements
GetAcceptFieldValueStringinAcceptMatchOperator.csto formatdecimal,double, andfloatvalues usingCultureInfo.InvariantCulture, ensuring consistent string output regardless of system locale.FormatInvarianthelper in bothAcceptAssert.cstest files, used for error message comparisons in tests. [1] [2]Method refactoring and static usage
CreateAcceptExceptionMessageandGetAcceptFieldValueStringinAcceptMatchOperator.csto be static methods, clarifying their usage and improving code readability. [1] [2]using System.Globalizationwhere necessary to support invariant formatting. [1] [2] [3]Snapshot name generation
GetMethodSnapshotNameinMSTestSnapshotFullNameReader.csto useSnapshotNameExtension.Create(...).ToParamsString()for generating parameter strings, likely improving consistency and maintainability of snapshot names.