Open
Conversation
Contributor
Author
|
Every time I tried using one call, the position would be messed up. I accepted this as an eldritch horror of the game and didn't bother digging into it any deeper. I guess I could look more into it today though. |
|
This changes seem to also touch part of code dealing with standalone manipulators. Have you verified if they still work as expected in all cardinal placements after this change? |
Contributor
Author
|
I have, yes. The positions are near identical except for in conditions outlined in the issue that prompted this PR. The code is easily modifiable to test with an adjacent manipulator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the position from which the laser is fired from block entities by taking the motion of the laser and clamping it to the perimeter of the cube from the center of the block. This could potentially break existing programs that depended on the weird prior behavior.
Program to demonstrate changes, to be run in a turtle with a laser in the left slot, some distance above the ground (for visibility):
fixes: #94