🐛 fix(recurring-events): allow someday recurring instance creation#1086
Merged
victor-enogwe merged 3 commits intomainfrom Oct 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug to allow someday recurring event instance creation by updating the payload structure and event handling logic for recurring events when transitioning to someday events.
- Updates type definitions to support recurring someday events with proper payload structure
- Modifies recurrence handling to set default occurrence counts for someday events
- Adds logic to convert recurring event frequencies to weekly when moving to someday
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| useRecurrence.ts | Updates hook to handle someday recurring events with proper type definitions and default occurrence counts |
| useRecurrence.test.ts | Updates test setup to use proper event assembly utilities and type definitions |
| useDraftActions.ts | Adds logic to modify recurring event rules when converting to someday events |
| someday.sagas.ts | Removes recurrence from events when converting someday to calendar events |
| event.sagas.ts | Adds proper scope handling for recurring event updates when converting to someday |
| event.types.ts | Updates payload type to use WithCompassId for better type safety |
...c/views/Forms/EventForm/DateControlsSection/RecurrenceSection/useRecurrence/useRecurrence.ts
Outdated
Show resolved
Hide resolved
packages/web/src/views/Calendar/components/Draft/hooks/actions/useDraftActions.ts
Show resolved
Hide resolved
...c/views/Forms/EventForm/DateControlsSection/RecurrenceSection/useRecurrence/useRecurrence.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the payload sent to the backend from the UI to support recurring event transition to someday events
Use Case
closes #1058