Skip to content

Comments

🐛 fix(recurring-events): allow someday recurring instance creation#1086

Merged
victor-enogwe merged 3 commits intomainfrom
fix-create-instances-for-recurring-someday-events-web-1058
Oct 8, 2025
Merged

🐛 fix(recurring-events): allow someday recurring instance creation#1086
victor-enogwe merged 3 commits intomainfrom
fix-create-instances-for-recurring-someday-events-web-1058

Conversation

@victor-enogwe
Copy link
Contributor

What does this PR do?

This PR updates the payload sent to the backend from the UI to support recurring event transition to someday events

Use Case

closes #1058

Copilot AI review requested due to automatic review settings October 8, 2025 11:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug to allow someday recurring event instance creation by updating the payload structure and event handling logic for recurring events when transitioning to someday events.

  • Updates type definitions to support recurring someday events with proper payload structure
  • Modifies recurrence handling to set default occurrence counts for someday events
  • Adds logic to convert recurring event frequencies to weekly when moving to someday

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
useRecurrence.ts Updates hook to handle someday recurring events with proper type definitions and default occurrence counts
useRecurrence.test.ts Updates test setup to use proper event assembly utilities and type definitions
useDraftActions.ts Adds logic to modify recurring event rules when converting to someday events
someday.sagas.ts Removes recurrence from events when converting someday to calendar events
event.sagas.ts Adds proper scope handling for recurring event updates when converting to someday
event.types.ts Updates payload type to use WithCompassId for better type safety

Copilot AI review requested due to automatic review settings October 8, 2025 11:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

@victor-enogwe victor-enogwe merged commit d1dbf9d into main Oct 8, 2025
4 checks passed
@victor-enogwe victor-enogwe deleted the fix-create-instances-for-recurring-someday-events-web-1058 branch October 8, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Someday recurrences aren't rendering in future weeks

1 participant