fix(web): add id and name attributes to input fields for accessibility#1144
Merged
tyler-dane merged 4 commits intomainfrom Oct 20, 2025
Merged
fix(web): add id and name attributes to input fields for accessibility#1144tyler-dane merged 4 commits intomainfrom
tyler-dane merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances web accessibility by adding id and name attributes to input fields across the application, addressing issue #1143.
Key Changes
- Added unique
idattributes to input fields for proper programmatic identification - Added descriptive
nameattributes to input fields for form handling and accessibility - Updated input fields across task management, onboarding, and login components
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web/src/views/Today/components/Task/Task.tsx | Added id and name attributes to task editing input field |
| packages/web/src/views/Today/components/AddTask/AddTaskActiveButton.tsx | Added id and name attributes to new task creation input |
| packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.tsx | Added id and name attributes to week and month task inputs in onboarding flow |
| packages/web/src/views/Login/Login.tsx | Added id and name attributes to email input field |
packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…SomedaySandbox.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…SomedaySandbox.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tyler-dane
changed the title
victor-enogwe
pushed a commit
that referenced
this pull request
Oct 24, 2025
#1144) * feat(web): add id and name attributes to input fields for accessibility * Update packages/web/src/views/Today/components/Task/Task.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update packages/web/src/views/Onboarding/steps/events/SomedaySandbox/SomedaySandbox.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1143