[draft] Support more eval configs #1
Draft
jfoote wants to merge 1 commit intoSwival:mainfrom
Draft
Conversation
- forward more skills-related cli directives from calibra to swival
- forward aws-profile similarly (for bedrock support)
- expose trial information to verify.sh
- via CALIBRA_<DIMENSION> env vars
- support running both verify.sh and reviewer (llm-as-judge) in a single
trial
- support per-task reviewer criteria
jedisct1
reviewed
May 6, 2026
Comment on lines
+463
to
+468
| if spec.variant.skills.skills_dirs: | ||
| for skills_dir in spec.variant.skills.skills_dirs: | ||
| argv.extend(["--skills-dir", str(skills_dir)]) | ||
| else: | ||
| argv.append("--no-skills") | ||
|
|
Contributor
There was a problem hiding this comment.
If this is already defined in [session], we will end up with duplicate flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some features that I drafted to support evaluating updates to https://github.com/fastly/fastly-agent-toolkit. I figured I'd share them in case they might be useful upstream.
I'll remove draft when I think this is ready for review.