Fixes To Broken Crafting System - #507
Conversation
Fixes the previously broken crafting system, with a major rework to the entirety of the recipe files.
Took 14 minutes
|
The bugs in the crafting system definitely are fixed with this PR, though the parsing is very very slow. |
strange, I'm not sure why it would've gotten slower. I guess in this case I'm making more checks to validate their craft and make sure their are no extra items. Someone else can check to see if there are any optimizations that could be made, but I'm not too sure. |
|
fix-1.diff |
|
Just saw this, thanks I'll test this when I'm home tommorow. |
Adds the fixes from ArikSquad, should optimize it a bit. Co-Authored-By: AriDev <75741608+ArikSquad@users.noreply.github.com>
|
Added on the new commit, should hopefully fix some of the parsing lag. It's hard for me to tell on my end, as I have a very laggy server in general for some reason. |
|
@Swofty-Developments did you get a chance to test this? |
|
This PR will one day get merged... I believe in it |
|
surely |
|
I don’t have access to a PC rn and according to Git the merge has conflicts :(. If the conflicts could be resolved I would merge it. |
|
Woohoo. I saw that too, I'll see when I get a chance to fix it up since it's so old |
|
Was too oudated, will make a new one |
4 participants
Fixes the previously broken crafting system, with a major rework to the entirety of the recipe files.