Fix the Docker and one-shot installer flow - #844
Merged
Conversation
ServiceStore was added alongside the store module but never listed here, so the asset 404s. Dockerfile.game_server fetches it with curl -f, which fails the whole image build and takes every Docker install down with it. Elections, guild, punishment and replay were missing for the same reason, though nothing downloads those yet.
config.docker.yml still used localhost for mongo and redis, which inside a container resolves to that container rather than the database. It now uses the compose service names rather than the container_name values, because Jedis parses redis-uri through java.net.URI, which rejects underscores in a hostname and throws InvalidURIException on hypixel_redis. Both Dockerfiles also baked config.example.yml in as the default, so the Docker config was never the file that actually got read.
The packer had no compose service, so nothing listened on 7270 and clients joined without the HUD, minimap or custom models. Its jar is now pulled alongside the others, and the download base URL is a build arg so the image can be built against a mirror or a locally served set of jars.
The generated config pointed limbo at picolimbo while the compose service is pico_limbo, and left resource-packs empty so the pack URL was never set. The asset archive now carries the resourcepacks sources as well as the worlds, since both are gitignored and a fresh clone has neither, so the presence check and the download timeout were widened to match the larger archive.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
The containers now read config.docker.yml themselves, so the rename step no longer does anything. Adds the resource pack server to the container list and to the port table, and notes that the pack URL is resolved by the client rather than inside the container, so remote players need it pointed at a reachable address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.