feat: experimentation table - #849
Open
ArikSquad wants to merge 10 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
ArikSquad
marked this pull request as ready for review
August 9, 2026 17:40
…land-furniture-system # Conflicts: # commons/src/generated/java/net/swofty/commons/skyblock/item/ItemType.java # configuration/skyblock/items/communitycenter/communitycenter.yml # configuration/skyblock/items/vanilla/items/others.yml
Swofty-Developments
requested changes
Aug 10, 2026
ArikSquad
commented
Aug 10, 2026
Swofty-Developments
requested changes
Aug 10, 2026
Swofty-Developments
left a comment
Swofty-Developments
left a comment
Owner
There was a problem hiding this comment.
Rebase it on main. Additionally it looks like enchantment table was added but don't you also need to modify some yaml for it to work?
…ion-table # Conflicts: # type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/item/ItemLore.java
Swofty-Developments
requested changes
Aug 10, 2026
Swofty-Developments
left a comment
Swofty-Developments
left a comment
Owner
There was a problem hiding this comment.
This PR doesn't launch, the EXPERIMENTATION_TABLE declares id: craftable which doesn't exist. Test the PR fully before resubmitting please.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #527
closes #360
TODO: