Merged
Conversation
mpysiak
force-pushed
the
import-poc
branch
3 times, most recently
from
fffe075 to
e9de8a2
Compare
mpysiak
force-pushed
the
import-poc
branch
3 times, most recently
from
3b2f2e9 to
12c24d0
Compare
NoResponseMate
approved these changes
Jul 15, 2025
|
|
||
| public function __invoke(Request $request, string $grid): Response | ||
| { | ||
| $request->attributes->set('_sylius', array_merge($request->attributes->get('_sylius', []), ['grid' => $grid])); |
Contributor
There was a problem hiding this comment.
Seems unneeded in this case
| } catch (\Throwable $e) { | ||
| /** @var Session $session */ | ||
| $session = $request->getSession(); | ||
| $session->getFlashBag()->add('error', 'sylius_import_export.import_failed: ' . $e->getMessage()); |
Contributor
There was a problem hiding this comment.
Does this concat work?
Comment on lines
+68
to
+70
| $this->entityManager->getClassMetadata($type); | ||
|
|
||
| return isset($data['id']) || isset($data['code']); |
Contributor
There was a problem hiding this comment.
Pretty sure we should read unique fields from the metadata and check if either of them is set. In case of customers we would base on the email for instance.
Comment on lines
+52
to
+55
| private function processFormConfig(ContainerBuilder $container): void | ||
| { | ||
| $container->setParameter('sylius_import_export.export_files_directory', '%kernel.project_dir%/var/export'); | ||
| } |
Contributor
There was a problem hiding this comment.
How is this a form config?
Comment on lines
+52
to
+53
| // Add import action only to main group for now | ||
| $this->addInActionGroup($grid, ActionGroupInterface::MAIN_GROUP); |
Contributor
There was a problem hiding this comment.
Pretty sure we won't have either a bulk or an item as they make no sense
| throw new \InvalidArgumentException(); | ||
| } | ||
|
|
||
| return json_decode($content, true, 512, \JSON_THROW_ON_ERROR); |
Contributor
There was a problem hiding this comment.
We could probably change all of these to symfony decoders further down the line
Comment on lines
+41
to
+52
| $importedCount = 0; | ||
| $resourceClass = $process->getResource(); | ||
| $denormalizer = $this->denormalizerRegistry->get($resourceClass); | ||
|
|
||
| foreach ($command->batchData as $recordData) { | ||
| $entity = $denormalizer->denormalize($recordData, $resourceClass); | ||
| $this->entityManager->persist($entity); | ||
|
|
||
| ++$importedCount; | ||
| } | ||
|
|
||
| $this->entityManager->flush(); |
Contributor
There was a problem hiding this comment.
IMO this should be wrapped in a transaction, so we'd save all or nothing per batch, reverting should also be easier in that case
| public function resolve(string $format): ImporterInterface | ||
| { | ||
| if (!$this->importers->has($format)) { | ||
| throw new InvalidArgumentException(sprintf('Importer for "%s" format was not found.', $format)); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new InvalidArgumentException(sprintf('Importer for "%s" format was not found.', $format)); | |
| throw new \InvalidArgumentException(sprintf('Importer for "%s" format was not found.', $format)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.