Conversation
mpysiak
force-pushed
the
import-poc
branch
3 times, most recently
from
31a3dc7 to
bc77ba8
Compare
Comment on lines
+27
to
+36
| if (!is_dir($this->importFilesDirectory)) { | ||
| mkdir($this->importFilesDirectory, 0755, true); | ||
| } | ||
|
|
||
| $fileName = uniqid() . '_' . $file->getClientOriginalName(); | ||
| $filePath = $this->importFilesDirectory . '/' . $fileName; | ||
|
|
||
| $file->move($this->importFilesDirectory, $fileName); | ||
|
|
||
| return $filePath; |
Contributor
There was a problem hiding this comment.
Would be nice to save the path on the process so it can be retried, or to perform cleanup after the import is done.
mpysiak
force-pushed
the
import-poc
branch
4 times, most recently
from
978e387 to
4f82a57
Compare
NoResponseMate
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.