Open
Conversation
Wojdylak
reviewed
Jan 28, 2026
diimpp
reviewed
Jan 29, 2026
config/services.php
Outdated
| $services = $container->services(); | ||
|
|
||
| $services->load('Sylius\\McpServerPlugin\\Tool\\', '../src/Tool/*') | ||
| ->autowire() |
Member
There was a problem hiding this comment.
Since this plugin goes into sylius namespace, it should follow existing conventions like not using autowire/autoconfigure and specifying all dependencies manually in this file.
@Wojdylak unless a new convention was made, this is critical.
src/Loader/PluginDiscoveryLoader.php
Outdated
| final readonly class PluginDiscoveryLoader implements LoaderInterface | ||
| { | ||
| public function __construct( | ||
| private LoggerInterface $logger = new NullLogger(), |
Member
There was a problem hiding this comment.
If possible, it should use bundle configured logger.
src/Loader/PluginDiscoveryLoader.php
Outdated
| { | ||
| $discoverer = new Discoverer($this->logger); | ||
| $state = $discoverer->discover( | ||
| basePath: dirname(__DIR__, 2), |
Member
There was a problem hiding this comment.
It's unfortunate, that getPath is not static.
for a fancy call like that.
https://github.com/symfony/symfony/blob/502b3648c0f6a8833d70065a7a54816ee69c9d9d/src/Symfony/Component/Intl/Intl.php#L115-L118
Fine as is though.
camilleislasse
force-pushed
the
feature/symfony-mcp-bundle
branch
from
a002213 to
45a383a
Compare
Wojdylak
reviewed
Jan 30, 2026
config/config.yaml
Outdated
|
|
||
| mcp: | ||
| app: 'Sylius MCP Server' | ||
| version: '0.1.0' |
Member
There was a problem hiding this comment.
Suggested change
| version: '0.1.0' | |
| version: '0.2.0' |
camilleislasse
force-pushed
the
feature/symfony-mcp-bundle
branch
from
45a383a to
f20107b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate from
php-mcp/servertosymfony/mcp-bundlefor better framework integration (includes profiler support)Changes
php-mcp/serverdependency withsymfony/mcp-bundle ^0.3.0PluginDiscoveryLoaderto register plugin tools viaLoaderInterfacemcp.yamlBC Breaks
sylius_mcp_server.yamltomcp.yamlsylius:mcp-server:starttomcp:server/mcpto/_mcp