Use BuildTestAppAction and fix DI tests#5
Merged
Wojdylak merged 2 commits intoSylius:mainfrom Jan 29, 2026
Merged
Conversation
10939b3 to
f22ff5a
Compare
Tests for discovery locations did not account for the default plugin location appended via `beforeNormalization`. Apply ECS trailing comma and unused import fixes.
f22ff5a to
fdf9fa1
Compare
Replace manual CI setup (PHP, Node, MySQL, Composer, Yarn, assets, fixtures) with `SyliusLabs/BuildTestAppAction@v4.0.0`. Add `doctrine:schema:update --force` before `doctrine:schema:validate` to handle Sylius core schema drift after migrations.
fdf9fa1 to
dfad287
Compare
Wojdylak
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual CI setup (PHP, Node, MySQL, Composer, Yarn, assets, fixtures) with
SyliusLabs/BuildTestAppAction@v4. Adddoctrine:schema:update --forcebeforedoctrine:schema:validateto handle Sylius core schema drift after migrations.Fix failing DI extension tests that did not account for the default plugin location appended via
beforeNormalizationinConfiguration. Apply ECS code style fixes.