[Shop] Fix paypal checkout when another payment method was selected during checkout#340
Merged
GSadee merged 6 commits intoSylius:1.6from Mar 17, 2025
Merged
[Shop] Fix paypal checkout when another payment method was selected during checkout#340GSadee merged 6 commits intoSylius:1.6from
GSadee merged 6 commits intoSylius:1.6from
Conversation
Comment on lines
128
to
129
| $this->orderPaymentsRemover->removePayments($order); | ||
| $this->orderProcessor->process($order); |
Contributor
There was a problem hiding this comment.
Add a comment as to why this is necessary/wat it do
Member
Author
There was a problem hiding this comment.
I think the test I added provides a good comment explaining the code I added.
GSadee
reviewed
Mar 14, 2025
mpysiak
approved these changes
Mar 14, 2025
GSadee
approved these changes
Mar 17, 2025
| } | ||
|
|
||
| /** @test */ | ||
| public function it_creates_pay_pal_order_from_cart_and_returns_its_data_if_payment_method_is_different_then_pay_pal(): void |
Member
There was a problem hiding this comment.
Suggested change
| public function it_creates_pay_pal_order_from_cart_and_returns_its_data_if_payment_method_is_different_then_pay_pal(): void | |
| public function it_creates_paypal_order_from_cart_and_returns_its_data_if_payment_method_is_different_than_paypal(): void |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.