Closed
Conversation
This PR was merged into the 1.6 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.6 (bug fixes, improvements) | Bug fix? | yes | New feature? | no | Related tickets | fixes #215 This will fix the wrong attribute "invoice_number" and add the "shipping_discount" to PayPalPurchaseUnit Commits ------- f4d63b2 Use constructor property promotion a97fada Fixed wrong attribute invoice_number b7ab860 Also transmit the shipping discount 1178884 Implemented suggested changes
…dee)
This PR was merged into the 1.6 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.6 (bug fixes, improvements)
| Bug fix? | yes
| New feature? | no
The UpdatePayPalOrderAction fails to update the PayPal order.
The call of ParameterBag::get('shipping_address') should return a scalar value but returns an array.
Commits
-------
6c00cf2 Removed unused constructor parameter
2396d67 Use constructor property promotion
5c6905e Fixed an issue where the parameterBag returns a non-scalar value
3e5f710 Added an upgrade note
63d31b9 Move note to the proper version in UPGRADE file
This PR was merged into the 1.6 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.6 (bug fixes, improvements) | Bug fix? | yes | New feature? | no A customer name can contain more than just a first name and last name. It could also contain a salutation, middle names or a title. Using only the first two words of the full_name is therefore not sufficient. The customer is also added to the address created. This means that the customer can change their shipping address after completing the order and can therefore influence the calculation of shipping costs and tax. Commits ------- a75f2d2 Do not add the customer to the address 464d258 Save the full name of the shipping address 415eda5 Removed unused constructor parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been generated automatically.
For more details see upmerge_pr.yaml.
Remember! The upmerge should always be merged with using
Merge pull requestbutton.In case of conflicts, please resolve them manually with usign the following commands:
If you use other name for the upstream remote, please replace
upstreamwith the name of your remote pointing to theSylius/PayPalPluginrepository.Once the conflicts are resolved, please run
git merge --continueand push the changes to this PR.