Remove deprecated code from SenderInterface#221
Open
Rafikooo wants to merge 3 commits intoSylius:3.0from
Open
Conversation
Wojdylak
reviewed
Feb 9, 2024
Contributor
|
The only problem with that is... we will have to release 3.0 xd |
Contributor
Author
If I am seeing correctly, deprecations were introduced in |
Contributor
|
Unfortunately, no, because once we released 2.0, we created a new contract. But it is not a big deal to do so |
Contributor
|
Let's maybe just open a 3.0 branch, why not? 😅 |
Zales0123
force-pushed
the
sender-outdated-code
branch
4 times, most recently
from
94a2b40 to
6c01c23
Compare
Rafikooo
force-pushed
the
sender-outdated-code
branch
from
6c01c23 to
c6fe673
Compare
Remove obsolete PHPStan ignore patterns for $ccRecipients and $bccRecipients parameters that now exist in the interface. Fix spec test to use CcAwareSenderAdapterInterface when testing sendWithCC functionality.
Address review feedback: use let() method to set up default construction with SenderAdapterInterface, and only use beConstructedWith() in tests that need different adapters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We neglected to remove outdated code before the 2.0 release