Add native typed properties and remove redundant declarations#277
Open
Rafikooo wants to merge 1 commit intoSylius:2.2from
Open
Add native typed properties and remove redundant declarations#277Rafikooo wants to merge 1 commit intoSylius:2.2from
Rafikooo wants to merge 1 commit intoSylius:2.2from
Conversation
Rafikooo
force-pushed
the
modernize/typed-properties
branch
2 times, most recently
from
373fee1 to
3848c81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mixedtype to untyped properties (Email::$id,EmailSendEvent::$message) and their return typesEmailDefaultAdapter(dispatcher is already set viaAbstractAdapter::setEventDispatcher())$idproperty