iGEM Quality Checker System#202
Draft
rkrishnasanka wants to merge 16 commits intoSynBioDex:developfrom
Draft
Conversation
Author
|
@jakebeal do you want to take a look at these notes ^^^ |
…asanka/SBOL-utilities into feature/poetry-migration
- Incorrect type annotations for `expand_configuration()` and `excel_to_sbol()` - All regex patterns should be raw strings
…rkrishnasanka/SBOL-utilities into feature/igem-package-qc-checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Will update description when completed)
Notes:
Updated:
I realized the easiest way to validate the parsed data would be to manually test against an entity. Here's the API:
By having the entity id being passed to the QC checker, we simplify the validation logic to be couple with the parsing logic.
I can add an additional parser for Excel row/column selection