Refactor: Generalize Complexity Score Calculation for Multiple Providers#332
Refactor: Generalize Complexity Score Calculation for Multiple Providers#332GeneCodeSavvy wants to merge 9 commits intodevelopfrom
Conversation
|
The test are passing on my system. The environment variables will have to be updated for CI / CD |
|
Before I approve and we merge, can you please provide the exact update that will be needed to make it pass? |
|
We need to update the secrets for the CI / CD. The secret For users, the credentials should also be stored in the specified format, in the
|
| '--provider', | ||
| 'idt', | ||
| '--credentials', | ||
| str(test_dir.parent / 'test_secret_idt_credentials.json'), |
There was a problem hiding this comment.
I have updated the secrets, but the tests are currently failing because some of the references are still to the old credentials and not the updated credentials.
2c40e4c to
8df2b78
Compare
|
The tests are currently failing due to a mismatch in word casing: This update should resolve the issue. |
8df2b78 to
a14277e
Compare
This PR refactors the DNA complexity score calculation to be more extensible and support multiple providers beyond IDT. The changes include generalizing function names, updating docstrings to be provider-agnostic, and preparing the script for future modularity improvements.
NOTE: This PR introduces breaking changes.
BREAKING CHANGE
Previous json file format:
{ "username": "hxrsh.09", "password": "xxxxxxxx", "ClientID": "harsh", "ClientSecret": "xxxxx-xxxx-xxxx-xxxx-xxxxxxxxx" }New json file format:
{ "idt": { "username": "hxrsh.09", "password": "xxxxxxxx", "client_id": "harsh", "client_secret": "xxxxx-xxxx-xxxx-xxxx-xxxxxxxxx" } }The new format stores the credentials as
{ "provider_name": { "key": "value", ... } }. It also adheres to snake case for all keys.