Skip to content

Add support for DEPOSIT-US node type #85

Description

@dchang

Trying to retrieve a DEPOSIT-US node via user.find_node(id: node_id) raises a KeyError: key not found: "DEPOSIT-US" error.

Looks like this would involve adding a new DepositUsNode class in line with the pattern surrounding the other node classes.

Also, changing:
https://github.com/synapsepay/SynapsePayRest-Ruby/blob/04f48e69f63c8a27422994f516d0a192bc543f9a/lib/synapse_pay_rest/models/node/node.rb#L95
to:

klass = NODE_TYPES_TO_CLASSES.[response['type']] || BaseNode 

should work in the meantime. Currently, fetch raises the error never reaching the default class.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions