Inline gif (media) rendering, unique chat colors for each user#772
Inline gif (media) rendering, unique chat colors for each user#772Osanosa wants to merge 2 commits intoSyncplay:masterfrom
Conversation
Osanosa
commented
Apr 23, 2026
Introduce inline media rendering for chat messages. Adds MessageTextView, ClickableMediaLabel, ChatOutputArea and InlineMediaWidget to fetch and display images/GIFs via QtNetwork.QNetworkAccessManager (with fallback text). Replace the single QTextBrowser with a scrollable ChatOutputArea and render chat items as individual MessageTextView/InlineMediaWidget widgets. Add media URL detection (_getInlineMediaUrl), message header formatting (_formatMessageHeader), and newMediaMessage; adjust newMessage to use addOutputWidget. Import QtNetwork and html.escape and initialize _chatMediaNetworkManager. Also remove automatic <br /> suffixes from some message formatting to avoid extra line breaks.
Import hashlib and add a static _usernameColorStyle(username) that computes an MD5-based hue (using the first two bytes mod 360) and returns an HSL color string adjusted for dark or light mode (uses global isDarkMode). Use this helper in showMessage and the message header to apply consistent, deterministic color styling to username spans.
|
It's neat that you can do this but I consider adding media embedding to be unnecessarily risky feature creep. In my view the change goes against key principles at #315 because:
|
|
Like idk it just parces direct file links and doesn't break anything So I don't see any compatibility issues as where not supported it is shown as text and where is supported it is a fun thing Do you find this problematic still? |
|
@Et0h any more feedback? it is fully compatible with previous versions, as it just detects direct media URLs. |
|
@Osanosa I'm going to back up Et0h with comment that this is a security nightmare. Downloading and rendering media is absolutely rife with vulnerabilities. To me, all other arguments around this are just fluff - inevitable security issues alone make this completely unsustainable burden to maintain for current core Syncplay developers. |
|
Okay this could be an optional toggle that users take risks to use it?
…On Sun, 26 Apr 2026, 17:04 Daniel Wróbel ***@***.***> wrote:
*daniel-123* left a comment (Syncplay/syncplay#772)
<#772 (comment)>
@Osanosa <https://github.com/Osanosa> I'm going to back up Et0h with
comment that this is a security nightmare. Downloading and rendering media
is absolutely rife with vulnerabilities.
To me, all other arguments around this are just fluff - inevitable
security issues alone make this completely unsustainable burden to maintain
for current core Syncplay developers.
—
Reply to this email directly, view it on GitHub
<#772 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATD6MCFQPUIALYQD2EVKTID4XYJQPAVCNFSM6AAAAACYC74WNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMRSGE4TSNBWGA>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ATD6MCGK56YBTDRRSGSIGOT4XYJQPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGIYTSOJUGYYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ATD6MCFP7JZOIG7JQWYCPR34XYJQPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGIYTSOJUGYYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
but it loads only media types? like cuh? |