Skip to content

Array views for sirf.Gadgetron data containers. #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KrisThielemans merged 75 commits into from
Oct 28, 2025
Merged

Array views for sirf.Gadgetron data containers. #1332

KrisThielemans merged 75 commits into from
Oct 28, 2025

Conversation

@evgueni-ovtchinnikov
Copy link
Contributor

@evgueni-ovtchinnikov evgueni-ovtchinnikov commented Jul 9, 2025 •
edited by KrisThielemans
Loading

Changes in this pull request

Array views for sirf.Gadgetron data containers implemented, delivering significant acceleration of data algebra.

Testing performed

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

evgueni-ovtchinnikov and others added 30 commits June 10, 2025 16:06
@evgueni-ovtchinnikov @casperdcl
add STIRImageData::address, params.size_t_par, ImageData.address
8aacd90
@casperdcl
{Image,Acquisition}Data.{__array_interface__,asarray()}
3dc4d76
@evgueni-ovtchinnikov @casperdcl
debugging & testing
f418d96
@casperdcl
ImageData.asarray(copy=None) numpy-like behaviour
44f9551 
- depends on #1317
@casperdcl
address review comments
abe7601
@evgueni-ovtchinnikov
pulled array-ptr, resolved conflicts
fbf83cc
@evgueni-ovtchinnikov
[ci skip] removed unused storage scheme settings from asarray.py demo
030d2ae
@evgueni-ovtchinnikov
added Python CI tests for asarray method
43612a3
@evgueni-ovtchinnikov
fixed CI tests for asarray (test_img_asarray->asarray4img)
d2fb53f
@evgueni-ovtchinnikov
got rid of docopt to fix CI tests for asarray
61a7089
@casperdcl
fix test args
676b2e8
@casperdcl
debugging
30d39f4
@casperdcl
debugging
4662710
@evgueni-ovtchinnikov
merged origin/array-ptr (fixed CI tests except demos)
9eb6c55
@evgueni-ovtchinnikov
Merge branch 'array-ptr' of https://github.com/SyneRBI/SIRF into arra…
ac459af 
…y-ptr
@evgueni-ovtchinnikov
trying to fix PET_DEMOS_PYTHON
6ac6ad4
@evgueni-ovtchinnikov
started working on array interface for ISMRMRD_Acquisition
b1ed678
@evgueni-ovtchinnikov
corrected the __array_interface__ data type code (f4 -> c8)
34fe063
@evgueni-ovtchinnikov
implemented and tested sirf.Gadgetron.Acquisition.asarray() method
c798ec6
@evgueni-ovtchinnikov
started working on array interface for sirf.Gadgetron.AcquisitionData
3353834
@evgueni-ovtchinnikov
implemented sirf.Gadgetron.AcquisitionDataView
ee5ae5b
@evgueni-ovtchinnikov
implemented sirf.Gadgetron.AcquisitionDataView algebra
27ef332
@evgueni-ovtchinnikov
started working on sirf.Gadgetron.ImageDataView algebra
b4bbdbd
@evgueni-ovtchinnikov
implemented sirf.Gadgetron.ImageDataView
e24ce92
@evgueni-ovtchinnikov
added images algebra performance comparison tests
1c9fc08
@evgueni-ovtchinnikov
merged array-ptr-reg onto array-ptr-mr and resolved conflicts
0ad7a2e
@evgueni-ovtchinnikov
added performance tests for nifti images algebra
ae6685d
@evgueni-ovtchinnikov
added acquisitions algebra performance comparison tests
38739fc
@evgueni-ovtchinnikov
added methods __isub__, norm and dot to ImageDataView
afa5db3
@evgueni-ovtchinnikov
introduced GadgetronDataView base class to avoid algebra methods dupl…
73e5f8d 
…ication
KrisThielemans
KrisThielemans requested changes Oct 15, 2025
View reviewed changes
@KrisThielemans KrisThielemans added this to the v3.9 milestone Oct 15, 2025
KrisThielemans
KrisThielemans reviewed Oct 16, 2025
View reviewed changes
KrisThielemans
KrisThielemans approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from copyright dates,, I'm ok to squash-merge this.

@casperdcl do you want to have a look, or ok to merge?

@casperdcl casperdcl linked an issue Oct 20, 2025 that may be closed by this pull request
numpy.asarray(...,copy) only introduced in numpy 2.0 #1338
Closed
casperdcl
casperdcl requested changes Oct 20, 2025
View reviewed changes
Copy link
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be needed

@KrisThielemans
Copy link
Member

KrisThielemans commented Oct 27, 2025

@casperdcl could you please check/approve this? It'd be good to get it across the finishing line. Feel free to squash-merge.

@KrisThielemans KrisThielemans merged commit d742956 into master Oct 28, 2025
6 checks passed
@KrisThielemans KrisThielemans deleted the array-ptr-mr branch October 28, 2025 08:35
@KrisThielemans
Copy link
Member

KrisThielemans commented Oct 28, 2025

@evgueni-ovtchinnikov please delete the various branches including this one when they are no longer needed (but be careful!)

@KrisThielemans KrisThielemans mentioned this pull request Oct 28, 2025
Closed
@casperdcl casperdcl mentioned this pull request Nov 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrisThielemans KrisThielemans KrisThielemans approved these changes

@casperdcl casperdcl casperdcl approved these changes

Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels

enhancement

Projects

None yet

Milestone

v3.9

Development

Successfully merging this pull request may close these issues.

numpy.asarray(...,copy) only introduced in numpy 2.0

4 participants

@evgueni-ovtchinnikov @KrisThielemans @casperdcl