Add subset algebra test #1342
Merged
Add subset algebra test #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskino
force-pushed
the
add_subset_algebra_test
branch
from
766d60b to
ca9cdb1
Compare
added to changes removed commented out code
paskino
force-pushed
the
add_subset_algebra_test
branch
from
ca9cdb1 to
8a02c63
Compare
paskino
force-pushed
the
add_subset_algebra_test
branch
2 times, most recently
from
03a0372 to
0c058e9
Compare
handle init pars set default storage scheme to file
paskino
force-pushed
the
add_subset_algebra_test
branch
from
0c058e9 to
c1ba035
Compare
KrisThielemans
approved these changes
Oct 26, 2025
Member
|
I suggest we merge this. However, #1111 will have to be reopened afterwards, as this PR doesn't fix that issue, it just tests if algebraic operations work with "in memory" (I don't know how to "unlink") |
Contributor
Author
|
To unlink you have to remove "closes " from the description (I did that). |
paskino
force-pushed
the
add_subset_algebra_test
branch
2 times, most recently
from
fdc06cc to
111caae
Compare
both test_division_by_scalar_zero and test_division_by_datacontainer_zero just assert True so override is not required
paskino
force-pushed
the
add_subset_algebra_test
branch
from
111caae to
c4585c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds unit tests for STIR
AcquisitionDatasubsets.Testing performed
Related issues
#1111
Checklist before requesting a review
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following: