Skip to content

Conversation

@KrisThielemans
Copy link
Member

  • call accumulate_Hessian_times_input in the no-subset case, as this will now be a bit faster (it's also a tiny bit less code)
  • give correct name of parameters in cstir.h to avoid confusion
  • add test for objective function with prior
  • clarify RDP exclusion of test case

@KrisThielemans
Copy link
Member Author

test_Hessian is currently failing here:

>       assert q <= .002
E       assert 8.509224046411635 <= 0.002

src/xSTIR/pSTIR/tests/test_ObjectiveFunction.py:83: AssertionError
----------------------------- Captured stdout call -----------------------------
norm of (x): 723.340454
norm of (x + dx): 724.102478
norm of grad(x): 12292.545898
norm of grad(x + dx): 12304.041016
norm of grad(x + dx) - grad(x): 11.830816
norm of H(x)*dx: 103.441887
relative difference: 8.509224

I believe this is because the STIR fix still needs to be fixed (as with that fix, my local test works ok). This would be a good thing: a test that fails because there's a bug!

We will need to update our STIR version requirements therefore. Obviously, with STIR 6.2, all Hessian tests will/should fail.

I think the easiest thing will be to require STIR 6.3. If people complain, we can always put in some code to allow 6.2, but throw explicit errors when the Hessian code is called (due to #1343 or UCL/STIR#1648)

@KrisThielemans
Copy link
Member Author

Depends on #1347

- call accumulate_Hessian_times_input in the no-subset case, as this will now be a
bit faster (it's also a tiny bit less code)
- give correct name of parameters in cstir.h to avoid confusion
- add test for objective function with prior
- clarify RDP exclusion of test case
@KrisThielemans KrisThielemans linked an issue Oct 28, 2025 that may be closed by this pull request
@KrisThielemans
Copy link
Member Author

I've rebased this on master, after the previous large merge. I've also updated to require STIR 6.3.

I now expect the DEVEL_BUILD=OFF job to fail, but ON to succeed.

@KrisThielemans
Copy link
Member Author

I now expect the DEVEL_BUILD=OFF job to fail, but ON to succeed.

indeed

@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov @paskino please update the SIRF-SuperBuild to use DEFAULT_STIR_TAG to current STIR master

@KrisThielemans
Copy link
Member Author

SIRF-SuperBuild updated, so the non-devel BUILD should now work.

@KrisThielemans
Copy link
Member Author

CI is now re-running

@KrisThielemans KrisThielemans changed the title minor improvements to STIR Hessian code minor improvements to STIR Hessian code (require STIR 6.3) Oct 30, 2025
@KrisThielemans KrisThielemans merged commit d5b4249 into SyneRBI:master Oct 30, 2025
8 of 9 checks passed
@KrisThielemans KrisThielemans deleted the HessianImprovements branch October 30, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update STIR requirements to v6.3

1 participant