-
Notifications
You must be signed in to change notification settings - Fork 29
minor improvements to STIR Hessian code (require STIR 6.3) #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor improvements to STIR Hessian code (require STIR 6.3) #1346
Conversation
|
I believe this is because the STIR fix still needs to be fixed (as with that fix, my local test works ok). This would be a good thing: a test that fails because there's a bug! We will need to update our STIR version requirements therefore. Obviously, with STIR 6.2, all Hessian tests will/should fail. I think the easiest thing will be to require STIR 6.3. If people complain, we can always put in some code to allow 6.2, but throw explicit errors when the Hessian code is called (due to #1343 or UCL/STIR#1648) |
|
Depends on #1347 |
- call accumulate_Hessian_times_input in the no-subset case, as this will now be a bit faster (it's also a tiny bit less code) - give correct name of parameters in cstir.h to avoid confusion - add test for objective function with prior - clarify RDP exclusion of test case
060cc77 to
baa00b3
Compare
|
I've rebased this on master, after the previous large merge. I've also updated to require STIR 6.3. I now expect the |
indeed |
|
@evgueni-ovtchinnikov @paskino please update the SIRF-SuperBuild to use |
|
SIRF-SuperBuild updated, so the non-devel BUILD should now work. |
|
CI is now re-running |
accumulate_Hessian_times_inputin the no-subset case, as this will now be a bit faster (it's also a tiny bit less code)