Skip to content

Conversation

@evgueni-ovtchinnikov
Copy link
Contributor

Changes in this pull request

Testing performed

Related issues

Fixes #1369

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

@evgueni-ovtchinnikov evgueni-ovtchinnikov self-assigned this Jan 28, 2026
@evgueni-ovtchinnikov evgueni-ovtchinnikov marked this pull request as draft January 28, 2026 15:30
@KrisThielemans
Copy link
Member

I think the best strategy is to just use GibbsRelativeDifferencePenalty everywhere. It should be backwards compatible with RelativeDifferencePrior. @ColomboMatte0 is that correct? (we don't need the surrogate stuff here AFAIK)

@ColomboMatte0
Copy link

It is backwards compatible with all the methods implemented in RelativedifferencePrior , we do not have SPS stuff for the RDP.

@evgueni-ovtchinnikov evgueni-ovtchinnikov marked this pull request as ready for review February 3, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the computation of the diagonal of RDP Hessian in SIRF.

4 participants