allow niftyreg to be built with opencl #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Ideally some of this should be in their export file (also for openmp). I guess it isn't?
|
Contributor
Author
|
No, just flags saying that NiftyReg was built with those libraries |
src/Registration/cReg/CMakeLists.txt
Outdated
| # If niftyreg was bulit with OpenCL | ||
| if (NIFTYREG_BUILT_WITH_OPENCL) | ||
| find_package(OpenCL REQUIRED) | ||
| if (OpenCL_FOUND) |
Member
There was a problem hiding this comment.
can dispense with that, as it's REQUIRED
src/Registration/cReg/CMakeLists.txt
Outdated
| find_package(OpenCL REQUIRED) | ||
| if (OpenCL_FOUND) | ||
| TARGET_LINK_LIBRARIES(Reg PUBLIC ${OpenCL_LIBRARIES}) | ||
| INCLUDE_DIRECTORIES(${OpenCL_INCLUDE_DIRS}) |
Member
There was a problem hiding this comment.
ideally also target-specific, but ok
Member
|
@rijobro merge in master to see |
Contributor
Author
|
merging as it looks fine to me (plus I doubt Travis has openCL anyway). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.