Conversation
|
Ahh sorry ,after writing that I don't have write access to the owner's repo's branch in discord, th0ma7 responded saying to make a new PR. I don't think I can update the owner's branch, I have tried adding their repo as a remote to my local repo, and merging my branch into theirs (the one the PR was created from). After resolving the merge conflicts I got permission errors when trying to push the changes of the related branch to the owner's repo. I think only people with write access to SynoCommunity/spksrc can make changes to a PR. |
|
Also, the old PR contains the beszel hub as well. I only have created a beszel agent package, and have not looked into the hub in any way. If I merge with that PR am I obliged to also update the hub package too? |
|
Hello @hgy59, I would really appreciate just a bit of guidance on how to continue with this package being merged. I have been asked to edit the existing PR. I cannot. What am I expected to do now? Perhaps I can merge the old PR into this new one? |
|
Hi @not-first, I've been reviewing both this PR and #6566, and I think there's a clean path forward that addresses the coordination concerns. Proposal: This PR focuses solely on
This way, each PR author maintains their own package, and users can install one or both depending on their needs. Suggested improvements for this PR:
The wizard implementation with SSH key validation, extra filesystems, and SMART device configuration looks good. Let me know if you'd like any help with these changes. |
|
Thank you for the quick review @mreid-tt. That proposal seems appropriate given the circumstances. I will make the following changes:
I attempted an update to the latest beszel version |
|
oops, I must have accidentally closed the PR with my last comment! Reopened it just now. I would appreciate some help with debugging this crash on the newer package version! AI seems to think it is a go runtime issue (as the newer beszel just updated to 1.26.0): However, I am naturally sceptical of accepting this as fully true without assistance from somebody more experienced in these issues. I am happy to provide any logs and information required, I am simply unsure of exactly what best helps debug in this scenario - package development is very new to me. I am happy to do this here or on discord. Regardless, the 1.18.3 release is working wonderfully. Beszel supports backwards compatibility with their agents meaning even if people are running the last hub version they will still be able to connect their NAS running the previous agent version. |
|
Just made the required changes. Awkwardly, every commit I push to my branch seems to close the PR... |
|
All requested changes have been applied. 👍 |
|
So I did a basic install and upgrade. I am not able to test with a Beszel Hub since I don't have one. I did however note these concerning warnings and errors in the service log: Can you share a bit more about how this agent software should work? Is there a data directory that should be configured? Do we need to capture a "HUB_URL environment variable" as part of the setup? How have you performed functional testing of the agent on your setup? |
|
The methods of agent communication with the hub can be read here. Essentially there are 2: SSH and Websocket. Websocket is tried first, then falls back to SSH. This package only supports SSH. Regarding those errors:
Enabling websocket connection support would require
I did not plan to support this in the initial version of the package, as I am not experienced with package development and don't feel confident in maintaining a storage folder between updates with correct permissions and future SQLite database operation. So in summary: Is there a data directory that should be configured? Do we need to capture a "HUB_URL environment variable" as part of the setup? How have you performed functional testing of the agent on your setup? |
I would suggest you revert 29a6827 given you have not observed these errors in your service log. Also, according to the https://beszel.dev/guide/environment-variables, this Unless we have a good reason for doing that it should probably remain enabled. Also, the correct syntax if you did want to disable it would be:
You can direct persons to this PR and provide guidance similar to our wiki, that they need to download the package from the checks/builds, decompress and manually install. |
This reverts commit 29a6827.
So here I am, excited about this agent ^^ I downloaded the evansport-7.1 build from the GH action workflow run and installed it manually. Not sure what to expect, so its hard for me to report bugs. Here is an overview of what I gathered instead. On the Beszel Hub:
Hope this helps. Thanks for your efforts =) |
|
addendum about my missing S.M.A.R.T info:
So I installed SynoCli Disk Tools and ran the setcap command. I also restarted the beszel-agent, but only effect was the error messages disappearing from the log: But the devices still don't show up in the beszel-hub. Also, lv throughput stays a flat 0. Likely related to |



Description
I added a package for the beszel agent, a monitoring tool used to connect to an externally running beszel hub. This package ONLY contains the agent.
It was created due to there being no easy way to install the agent on your NAS.
If SMART monitoring is wanted the user must also install the SynoCli Disk Tools package and run the command:
sudo setcap 'cap_sys_rawio+ep' $(readlink -f /usr/local/bin/smartctl)as root on their NAS.I am slightly unsure where to put this. I plan to contribute it to the beszel documentation, which container similar instruction for setting up correct permissions for other systems.
I have added a simple notice to refer to beszel documentation in the package description.
Checklist
all-supportedcompleted successfullyType of change