fix(use_timeout_fn): cancel pending timer on start()#307
Merged
Conversation
`use_timeout_fn`'s `start` previously overwrote the stored `TimeoutHandle` without clearing it, leaving the prior browser `setTimeout` scheduled. Both the old and new callbacks would fire, silently breaking the "call start() again to reschedule" pattern. This matches VueUse's `useTimeoutFn.start`, which explicitly clears before re-scheduling and is the behavior the leptos-use API surface advertises by being a VueUse port. Closes Synphonyte#306
Contributor
Author
|
this also adds a test which demonstrates the problem, and fails without the patch. |
Contributor
|
This is excellent work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_timeout_fn'sstartpreviously overwrote the storedTimeoutHandlewithout clearing it, leaving the prior browsersetTimeoutscheduled. Both the old and new callbacks would fire, silently breaking the "call start() again to reschedule" pattern.This matches VueUse's
useTimeoutFn.start, which explicitly clears before re-scheduling and is the behavior the leptos-use API surface advertises by being a VueUse port.Closes #306