This repository was archived by the owner on Mar 2, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #36
curveCoordinates
,highlightedSections
を atom に置き換えintervals
とbeats
を atom で定義curveCoordinates
,highlightedSections
が更新されるとintervals
とbeats
も勝手に更新されるsettingsAtom
を追加bpnAtom
,octaveRangeAtom
... を1つ1つ持ってくると冗長すぎたbarCount * beatCount
等をまとめたやつを作ってもいいかも → totalBeatCount 等のatomを追加する #38music
を atom に置き換えintervals
とbeats
とsettings
が変わったら music も再生成されるように色々やってるけど、これまでの動作自体に変化がなければ(一旦は)問題ないです!
atom の流れは↓な感じです
左端の atom が更新されると矢印の先の atom も合わせて更新されていきます