Fix response error when read-only and write-only registers overlap#183
Merged
amykyta3 merged 2 commits intoSystemRDL:mainfrom Nov 16, 2025
Merged
Fix response error when read-only and write-only registers overlap#183amykyta3 merged 2 commits intoSystemRDL:mainfrom
amykyta3 merged 2 commits intoSystemRDL:mainfrom
Conversation
added 2 commits
November 16, 2025 00:38
amykyta3
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #178 by flipping the polarity of the invalid_rw check. Instead of checking if an access is invalid, I now check if a valid access is performed.
If an access is performed to an existing address, but no valid R/W is performed, I then assert the error flag.
Note 1: I updated the error test by removing unnecessary external register tests, but replacing them with tests for external blocks (where we never asserts errors for bad RW access).
Note 2: I had to revert the change in the test_parity test #182 for Xilinx, as it seems to behave differently with force/release.
Checklist