Skip to content

Fix response error when read-only and write-only registers overlap#183

Merged
amykyta3 merged 2 commits intoSystemRDL:mainfrom
sbaillou:dev/err_bad_rw_reg_overlap
Nov 16, 2025
Merged

Fix response error when read-only and write-only registers overlap#183
amykyta3 merged 2 commits intoSystemRDL:mainfrom
sbaillou:dev/err_bad_rw_reg_overlap

Conversation

@sbaillou
Copy link
Contributor

Description of change

Fixes #178 by flipping the polarity of the invalid_rw check. Instead of checking if an access is invalid, I now check if a valid access is performed.
If an access is performed to an existing address, but no valid R/W is performed, I then assert the error flag.

Note 1: I updated the error test by removing unnecessary external register tests, but replacing them with tests for external blocks (where we never asserts errors for bad RW access).

Note 2: I had to revert the change in the test_parity test #182 for Xilinx, as it seems to behave differently with force/release.

Checklist

  • I have reviewed this project's contribution guidelines
  • This change has been tested and does not break any of the existing unit tests. (if unable to run the tests, let us know)
  • If this change adds new features, I have added new unit tests that cover them.

@amykyta3 amykyta3 merged commit efbddcc into SystemRDL:main Nov 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Write response error when read-only and write-only registers are mapped to the same address

2 participants