Skip to content

Skip read/write buffering implementation for external nodes #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darsor wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip read/write buffering implementation for external nodes #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba8101a
skip read/write buffering implementation for external nodes
darsor Feb 5, 2026
bba99e7
improve external node skipping for rbuf/wbuf impl
darsor Feb 5, 2026
d76539d
fix mypy type error
darsor Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/peakrdl_regblock/read_buffering/implementation_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from typing import TYPE_CHECKING
from typing import TYPE_CHECKING, Optional

from systemrdl.node import RegNode
from systemrdl.node import RegNode, AddressableNode
from systemrdl.walker import WalkerAction

from ..forloop_generator import RDLForLoopGenerator

Expand All @@ -17,6 +18,11 @@ def __init__(self, rbuf: 'ReadBuffering') -> None:
"read_buffering/template.sv"
)

def enter_AddressableComponent(self, node: AddressableNode) -> Optional[WalkerAction]:
if node.external:
return WalkerAction.SkipDescendants
return super().enter_AddressableComponent(node)

def enter_Reg(self, node: RegNode) -> None:
super().enter_Reg(node)

Expand Down
10 changes: 8 additions & 2 deletions src/peakrdl_regblock/write_buffering/implementation_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from typing import TYPE_CHECKING
from typing import TYPE_CHECKING, Optional
from collections import namedtuple

from systemrdl.node import RegNode
from systemrdl.node import RegNode, AddressableNode
from systemrdl.walker import WalkerAction

from ..forloop_generator import RDLForLoopGenerator

Expand All @@ -18,6 +19,11 @@ def __init__(self, wbuf: 'WriteBuffering') -> None:
"write_buffering/template.sv"
)

def enter_AddressableComponent(self, node: AddressableNode) -> Optional[WalkerAction]:
if node.external:
return WalkerAction.SkipDescendants
return super().enter_AddressableComponent(node)

def enter_Reg(self, node: 'RegNode') -> None:
super().enter_Reg(node)

Expand Down