Add factory registration for top-level blocks#29
Open
mballance wants to merge 1 commit intoSystemRDL:mainfrom
Open
Add factory registration for top-level blocks#29mballance wants to merge 1 commit intoSystemRDL:mainfrom
mballance wants to merge 1 commit intoSystemRDL:mainfrom
Conversation
Signed-off-by: Matthew Ballance <matt.ballance@gmail.com>
umarcis
reviewed
Oct 15, 2024
umarcis
left a comment
umarcis
left a comment
There was a problem hiding this comment.
I was also facing the same issue, and have to add this particular line of factory registration in register model myself, then it runs without any error, however it should be approved so that everyone use it without facing this issue...
|
Hi @amykyta3 / @zhajio1988 / @krcb197 / @Dragon-Git / @darsor / @drom / @MarekPikula If any one of you maintaining this repo, can you guys please help to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds factory registration for register blocks.
UVM encourages registering component and object classes with the factory. While it's not necessary to register all classes (eg individual registers), registering top-level classes is a good compromise.
In my case, the UVM tool I use to create environments (UVM Framework) assumes that the top-level register block can be created via the factory.