Patch 1 Swap map → std::map driver_apator08, 162, 172 - #301
Open
ozmatox wants to merge 12 commits into
Open
Conversation
add 'flow temperature' field for hydrus watermeter
…_unismart Add battery field for Unismart driver
Update driver_hydrodigit.cpp frame 0x03
Add C1 link mode to Hydrus driver
Update driver_hydrodigit.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While compiling the esp8266, I get the error "error: reference to 'map' is ambiguous"
(nodemcuv3+cc1101)
Classic name conflict in the ESP8266 (Arduino)
The compiler sees two different things named map:
std::map from C++ ()
the map() function from Arduino
long map(long, long, long, long, long);
On the ESP8266, Arduino.h is pulled in very early, messing up the namespace.
The result: lines like:
map<string, pair<int, DVEntry>> vendor_values;
are ambiguous → the compiler doesn't know if it's the map() function or the std::map container.
Wmbus component Apator driver files (driver_apator08, 162, 172)
This isn't usually available on the ESP32—the ESP8266 is more of an "Arduino legacy" approach.
The simplest and correct solution:
Swap map → std::map
Swap string → std::string
Swap pair → std::pair