Validate meter types against the names drivers actually register - #427
Open
kpustelnik wants to merge 1 commit into
Open
Validate meter types against the names drivers actually register#427kpustelnik wants to merge 1 commit into
kpustelnik wants to merge 1 commit into
Conversation
kpustelnik
marked this pull request as draft
August 6, 2026 17:27
kpustelnik
marked this pull request as ready for review
August 6, 2026 17:37
Contributor
Author
|
Hi @SzczepanLeon ! Mind taking a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wmbus_common took the list of valid meter types from driver file names, but createMeter() resolves a type through lookupDriverInfo(), which matches the names passed to di.setName() / di.addNameAlias(). The two sets differ, so eight valid names were rejected (multical302, multical303, multical403, multical602, multical603, multical803 from driver_kamheat.cpp; and whe5x, whe46x from driver_qcaloric.cpp). Conversely, a driver whose setName() disagreed with its file name would only be caught at boot.
Validation now reads those names out of the driver sources, so a type is checked against exactly what the firmware will resolve. drivers: all and KEEP_DRIVER symbol generation resolve through the driver's source file, so aliases collapse to one source file and one reference.