Skip to content

Fix comment handling - #1

Open
bemyak wants to merge 3 commits into
Szeliga:masterfrom
bemyak:fix-comments
Open

Fix comment handling#1
bemyak wants to merge 3 commits into
Szeliga:masterfrom
bemyak:fix-comments

Conversation

@bemyak

@bemyak bemyak commented Sep 16, 2025

Copy link
Copy Markdown

See the first comment for the gist of the changes.

With the current implementation, this is not parsed correctly:

@startuml
' Test comment
System(foo, "bar")
' Other comment

Everything between single quotes is treated as a string.

I tried to keep the changes minimal and backwards-compatible, but I'd consider combining string and single_quote_string into one directive: string: $ => choice(/"[^"]*?"/, /'[^']*?'/),.

Should resolve gabeins/zed-plantuml#5

@atassis

atassis commented Jan 7, 2026

Copy link
Copy Markdown

Hi there. What stops us from merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comment quote doesn't work as intended

2 participants