This repository was archived by the owner on Jun 25, 2026. It is now read-only.
Fix Docker dev container permissions and isolate node_modules - #23
Merged
Conversation
Run the container as a non-root user matching the host UID/GID to fix file permission issues with bind mounts. Install node_modules in /deps inside the container and symlink them at startup, preventing Docker from creating a root-owned node_modules directory on the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modulesin/depsand symlink at startup to prevent a root-ownednode_moduleson the hostnpm ciis needed for editor supportCloses #22
Test plan
just up devand verify the container starts without errorshttp://localhost:5173node_modulesdirectory appears on the hostnpm cilocally and confirm VSCode resolves types correctly