feat(service worker): add service worker functionality by DanielHabenicht · Pull Request #101 · T-Systems-MMS/phonebook

DanielHabenicht · 2019-07-18T14:05:38Z

resolves #87

DanielHabenicht · 2019-07-18T14:06:46Z

Do not merge till at least 29.07 in order to auto uninstall the old service worker in our company.

mmsgithub-ci · 2019-12-02T12:22:22Z

Preview Environment ready at https://pr-101.demo-phonebook.me

Service worker is not working correctly if schema is in it https://stackoverflow.com/questions/56520967/angular-service-worker-offline-caching-is-not-working-when-ive-deployed-in-serv

mmsgithub-ci · 2019-12-02T13:00:35Z

Preview Environment ready at https://pr-101.demo-phonebook.me

DanielHabenicht · 2019-12-03T09:10:38Z

There is still a bug:
angular/angular#23613

Caused by us changing the environment variables in the index.html, possible solutions:

remove the index.html hash from ngsw.json
recalculate the hash.

This makes the service-worker work. Without it index.html would not be cached by the service worker

DanielHabenicht · 2019-12-03T13:36:04Z

@mschwrdtnr @paule96 @marcuskrahl @FrankLambrette please have a look at the PR-Preview and look out for issues that might come from the service worker (outdated info, double network requests, if it is working offline, for both languages etc.)

Please write back if any issues arise. If not we can merge and finally it will work for both English and German and completely offline 🎉 .

mmsgithub-ci · 2019-12-03T13:40:29Z

Preview Environment ready at https://pr-101.demo-phonebook.me

mmsgithub-ci · 2019-12-03T14:17:08Z

Preview Environment ready at https://pr-101.demo-phonebook.me

mmsgithub-ci · 2019-12-03T14:50:05Z

Preview Environment ready at https://pr-101.demo-phonebook.me

VanLampe · 2019-12-04T10:48:20Z

@DanielHabenicht could you please explain, how the page should work offline, so what should load and so on? If I set the network settings in chrome dev tools to offline, the page wont load any content anymore.

DanielHabenicht · 2019-12-05T15:20:26Z

/azp run T-Systems-MMS.phonebook-preview

azure-pipelines · 2019-12-05T15:20:37Z

Azure Pipelines successfully started running 1 pipeline(s).

mmsgithub-ci · 2019-12-05T15:58:03Z

Preview Environment ready at https://pr-101.demo-phonebook.me

mschwrdtnr · 2019-12-08T15:29:42Z

@DanielHabenicht could you please explain, how the page should work offline, so what should load and so on? If I set the network settings in chrome dev tools to offline, the page wont load any content anymore.

Will test it after your answer :)

DanielHabenicht · 2019-12-09T16:12:54Z

I already described what to test here

look out for issues that might come from the service worker (outdated info, double network requests, if it is working offline, for both languages etc.)

Everything should work as if you are online. Report back everything that does not work.

DanielHabenicht · 2019-12-09T16:13:15Z

/azp run T-Systems-MMS.phonebook-preview

azure-pipelines · 2019-12-09T16:13:26Z

Azure Pipelines successfully started running 1 pipeline(s).

mmsgithub-ci · 2019-12-09T16:26:56Z

Preview Environment ready at https://pr-101.demo-phonebook.me

VanLampe · 2019-12-10T06:54:01Z

@DanielHabenicht does the page needs a initial connection for working offline afterwards?

Not evrything can be loaded properly:

Rooms are not loading, so no content is shown if offline.

DanielHabenicht · 2019-12-10T08:25:58Z

@DanielHabenicht does the page needs a initial connection for working offline afterwards?

Does the page load if you are offline or not?

Not evrything can be loaded properly:

Rooms are not loading, so no content is shown if offline.

That's ok, dynamic content can't be preloaded. But everything you already searched for will be there.

VanLampe · 2019-12-10T09:22:22Z

@DanielHabenicht does the page needs a initial connection for working offline afterwards?

Does the page load if you are offline or not?

If I reload the page with connection set to offline, it is not loading. But if I dont reload, evrything exept the rooms is loaded fine

DanielHabenicht · 2019-12-10T10:02:43Z

Can you send me some more information via chat?

DanielHabenicht · 2019-12-17T16:15:37Z

@T-Systems-MMS/phonebook-developers ping

mschwrdtnr · 2019-12-18T09:38:29Z

Phonebook.Frontend/src/app/app.component.ts

+    if (!this.store.selectSnapshot(AppState.serviceWorkerNotificationDisplayed)) {
+      if ('serviceWorker' in navigator) {
+        this.swUpdates.activated.subscribe(active => {
+          if (active.current) {


When should that be opened? Didn't got any message.

okay. Got it.

should have opened! I will investigate. Good catch

I got one dialog "Update your site" or something like..

Phonebook.Frontend/index_rehash.sh

mschwrdtnr

Everything works for me. Tested it locally, the preview and with different languages.

DanielHabenicht · 2019-12-18T09:51:27Z

/azp run T-Systems-MMS.phonebook-preview

azure-pipelines · 2019-12-18T09:51:38Z

Azure Pipelines successfully started running 1 pipeline(s).

mmsgithub-ci · 2019-12-18T10:04:57Z

Preview Environment ready at https://pr-101.demo-phonebook.me

DanielHabenicht · 2020-03-26T22:45:01Z

Blocked by Angular i18n, depending on $localize being runtime or AOT compiled.

DanielHabenicht added 5 commits July 12, 2019 11:13

fix(service-worker): remove service worker

ffdf39a

chore(angular): remove unneeded copy files

88007b9

fix(service-worker): readd manifest with angular 8

506f0e1

fix(service-worker): remove ngsw paths

1c33423

wip

0f96060

DanielHabenicht marked this pull request as ready for review December 2, 2019 10:46

DanielHabenicht added 4 commits December 2, 2019 11:59

Merge branch 'master' into feat/add-service-worker

a41ed37

chore(docker): update dockerignore

a55e01b

fix(nginx): remove 404 paths

f3d4d9c

fix(docker): add ngsw-config.json

a9e53f7

fix(angular): service worker

b3a0ad2

Service worker is not working correctly if schema is in it https://stackoverflow.com/questions/56520967/angular-service-worker-offline-caching-is-not-working-when-ive-deployed-in-serv

fix(service-worker): update hashes in ngsw.json

d4e2b18

This makes the service-worker work. Without it index.html would not be cached by the service worker

fix(service-worker): fix replace string in non debug case

3b48b8b

fix(service-worker): make it path agnostic

36fe4cb

DanielHabenicht requested review from a team, Zeroks77, mschwrdtnr and paule96 and removed request for paule96 December 17, 2019 16:15

mschwrdtnr reviewed Dec 18, 2019

View reviewed changes

mschwrdtnr approved these changes Dec 18, 2019

View reviewed changes

Zeroks77 approved these changes Dec 19, 2019

View reviewed changes

DanielHabenicht added the BLOCKED This Issue is blocked. Have a look in the comments. label Dec 19, 2019

paule96 marked this pull request as draft September 8, 2020 12:28

Conversation

DanielHabenicht commented Jul 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielHabenicht commented Jul 18, 2019

Uh oh!

mmsgithub-ci commented Dec 2, 2019

Uh oh!

mmsgithub-ci commented Dec 2, 2019

Uh oh!

DanielHabenicht commented Dec 3, 2019

Uh oh!

DanielHabenicht commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmsgithub-ci commented Dec 3, 2019

Uh oh!

mmsgithub-ci commented Dec 3, 2019

Uh oh!

mmsgithub-ci commented Dec 3, 2019

Uh oh!

VanLampe commented Dec 4, 2019

Uh oh!

DanielHabenicht commented Dec 5, 2019

Uh oh!

azure-pipelines bot commented Dec 5, 2019

Uh oh!

mmsgithub-ci commented Dec 5, 2019

Uh oh!

mschwrdtnr commented Dec 8, 2019

Uh oh!

DanielHabenicht commented Dec 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielHabenicht commented Dec 9, 2019

Uh oh!

azure-pipelines bot commented Dec 9, 2019

Uh oh!

mmsgithub-ci commented Dec 9, 2019

Uh oh!

VanLampe commented Dec 10, 2019

Uh oh!

DanielHabenicht commented Dec 10, 2019

Uh oh!

VanLampe commented Dec 10, 2019

Uh oh!

DanielHabenicht commented Dec 10, 2019

Uh oh!

DanielHabenicht commented Dec 17, 2019

Uh oh!

mschwrdtnr Dec 18, 2019

Choose a reason for hiding this comment

Uh oh!

mschwrdtnr Dec 18, 2019

Choose a reason for hiding this comment

Uh oh!

DanielHabenicht Dec 18, 2019

Choose a reason for hiding this comment

Uh oh!

mschwrdtnr Dec 18, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mschwrdtnr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielHabenicht commented Dec 18, 2019

Uh oh!

azure-pipelines bot commented Dec 18, 2019

Uh oh!

mmsgithub-ci commented Dec 18, 2019

Uh oh!

DanielHabenicht commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

DanielHabenicht commented Jul 18, 2019 •

edited

Loading

DanielHabenicht commented Dec 3, 2019 •

edited

Loading

DanielHabenicht commented Dec 9, 2019 •

edited

Loading

mschwrdtnr left a comment •

edited

Loading