fix(no-ie): add js snipped to check for internet explorer (#445)#519
fix(no-ie): add js snipped to check for internet explorer (#445)#519
Conversation
check for ie links to open pb in other common browsers
|
Sorry that it took so long, but I did not found time to start working at this. Please just tell me, what you guys think of the solution. I did not spend much time in css styling. |
|
Preview Environment ready at https://pr-519.demo-phonebook.me |
|
Bis auf die zwei Kommentare sieht es sehr gut aus. Kein Problem das es länger gedauert hat. |
|
@DanielHabenicht thanks for your review! Does the calls to open the application with chrome, firefox and opera work for you? If I try that in the demo-environment it does not. |
|
Nope but, working on my comment should fix it. |
I had to change security settings and enable ActiveX..now IE asks if I want to execute firefox for example. I could not find a way to open the app in firefox, chrome or opera without ActiveX. |
Co-Authored-By: DanielHabenicht <daniel-habenicht@outlook.de>
|
Preview Environment ready at https://pr-519.demo-phonebook.me |
|
I think we shouldn't use ActiveX in this context. Just provide a link where users can download the other browser. They can then switch it manually. |
I also think, ActiveX isnt a good solution. I will revoke those changes. But I will keep the Link to open with edge, because this works without ActiveX. |
add download links for modern browsers
|
@DanielHabenicht I updated the code, please let me know what you think. |
|
Preview Environment ready at https://pr-519.demo-phonebook.me |
mschwrdtnr
left a comment
mschwrdtnr
left a comment
There was a problem hiding this comment.
Finde es sehr gut, dass man mit einem Klick direkt zu Edge gelangt. Spart dem Nutzer nochmal 10 Sekunden fürs öffnen eines Browsers und öffnen des Phonebooks (y)
Co-Authored-By: DanielHabenicht <daniel-habenicht@outlook.de>
VanLampe
dismissed stale reviews from DanielHabenicht and mschwrdtnr
via
c002afb
Co-Authored-By: DanielHabenicht <daniel-habenicht@outlook.de>
Co-Authored-By: DanielHabenicht <daniel-habenicht@outlook.de>
| top: 38%; | ||
| left: 38%; | ||
| position: absolute; |
There was a problem hiding this comment.
| top: 38%; | |
| left: 38%; | |
| position: absolute; | |
| margin: auto; | |
| height: 200px; |
There was a problem hiding this comment.
damit ist es auch genau in der Mitte
| position: absolute; | ||
| } | ||
| .pb-no-ie a { | ||
| cursor: pointer; |
There was a problem hiding this comment.
das ist eigentlich überfüssig, <a> sind immer mit pointer belegt :)
|
Wie machen wir das eigentlich mit der Übersetzung? Kannst du dafür eine Issue aufmachen? |
|
Preview Environment ready at https://pr-519.demo-phonebook.me |
Co-Authored-By: DanielHabenicht <daniel-habenicht@outlook.de>
|
Preview Environment ready at https://pr-519.demo-phonebook.me |
Meinst du denn, dass man dafür wirklich eine Übersetzung brauchst? Ich hatte das auch erst überlegt, aber fand dann den Aufwand etwas zu hoch, da die Message ja eigentlich recht klar ist.. |
dann vielleicht nur auf englisch? |
|
Kannst du außerdem die Komponenten löschen die dadurch nun überflüssig geworden sind? |
|
Hey @FrankLambrette how is it going? If I am right you only need to provide an English text and don't need to translate it :) |
|
And remove old is deps |
|
Stuff to resolve this PR🎉 🎉
|
5 participants
resolves #445
check if internet explorer is used and offer links to more modern/common browsers