feat(dashboard): Show Team on Dashboard#592
Open
Frieda-Hentschel wants to merge 37 commits intomasterfrom
Open
feat(dashboard): Show Team on Dashboard#592Frieda-Hentschel wants to merge 37 commits intomasterfrom
Frieda-Hentschel wants to merge 37 commits intomasterfrom
Conversation
This reverts commit 3dc88d7.
Frieda-Hentschel
requested review from
DanielHabenicht,
Zeroks77,
mschwrdtnr and
paule96
Collaborator
|
Preview Environment ready at https://pr-592.demo-phonebook.me |
paule96
reviewed
Apr 7, 2020
Phonebook.Frontend/src/app/pages/dashboard/components/overview/dashboard.component.html
Outdated
Show resolved
Hide resolved
paule96
reviewed
Apr 7, 2020
Phonebook.Frontend/src/app/pages/dashboard/components/overview/dashboard.component.scss
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/bookmarked/bookmarked.component.html
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/overview/dashboard.component.ts
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/overview/dashboard.component.ts
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/team/team.component.html
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/team/team.component.html
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/team/team.component.ts
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/dashboard-routing.module.ts
Outdated
Show resolved
Hide resolved
Member
|
Co-authored-by: Restyled.io <commits@restyled.io>
Collaborator
|
/azp run T-Systems-MMS.phonebook-preview |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run T-Systems-MMS.phonebook-preview |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Preview is not working at the moment ;( |
Phonebook.Frontend/src/app/services/api/current-user.service.ts
Outdated
Show resolved
Hide resolved
Phonebook.Frontend/src/app/pages/dashboard/components/team/team.component.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run T-Systems-MMS.phonebook-preview |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Restyled.io <commits@restyled.io>
Collaborator
|
Preview Environment ready at https://pr-592.demo-phonebook.aquiver.de |
DanielHabenicht
previously approved these changes
Dec 17, 2020
Phonebook.Frontend/src/app/services/api/current-user.service.ts
Outdated
Show resolved
Hide resolved
DanielHabenicht
previously approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: The user could only view their bookmarked people on the dashboard.
Now: User can switch between their team and bookmarks. If the user doesn't have any bookmarks, the dashboard will automatically display the team and next to the dashboard button it says how to bookmark somebody. Otherwise, the bookmarks are the default view. If the user isn't logged in, there won't be the option to look at the team.
Open question: Currently, the team is displayed in the following order: supervisor, assistents, employees, and learners. Should we add subheadings to showcase the different groups or leave it the way it is now?