feat(backend): New Backend and authentication for Phonebook data. by paule96 · Pull Request #7 · T-Systems-MMS/phonebook

paule96 · 2019-04-05T00:21:16Z

The following are the changes, most of them are breaking changes:

replace the json file with a real backend
- the backend connects directly to a database
- currently, it try to return the same stuff as the old JSON file
Open Source the backend
add authentification to the people data
- currently, supported is WsFederation over Azure or ADFS (and tested)

There are some issues that currently are known:

the search for numbers is broken
- this is not related to this change but good to know (Search is broken #591 )
the last hierarchy in the org structure isn't visible in any view
- organigram
- users supervisor
- Users organigram information
after login the user is redirected to / and not to the path the redirection starts. (New Backend: user authenitcation flow #586 )
the picture backend asked for login
- this will change soon because we plan to use the same auth like this backend.

But we must ship this because the old source is broken. (after more than 15 years!)
So let's

BREAKING CHANGE
closes #18
closes #271

- warning: we are now officell unstable because the oracle dependencie is beta...

paule96 · 2019-04-05T00:23:50Z

This pr is blocked by a missing build infrastructure! I add this later. @DanielHabenicht we must do some internal discussions about this...

DanielHabenicht

Apart from my comment it looks good! But we can add swashbuckle later if you want.

Phonebook.Source.PeopleSoft/src/Phonebook.Source.PeopleSoft/Controllers/BuildingController.cs

paule96 · 2019-06-23T18:43:34Z

Good news @DanielHabenicht : This PR will continue on Monday :)

- improve performance - beginn removing cycle refs - enabled query errors if client evaluation is need - endable usersecrets

paule96 · 2019-10-02T18:12:57Z

think about query caching with:

https://github.com/VahidN/EFSecondLevelCache.Core
or this:

https://github.com/SteffenMangold/EntityFrameworkCore.Cacheable/

things that are also todo is to add maybe OData or something like this to allow querying data.

DanielHabenicht · 2019-10-03T20:17:46Z

I think just provide the bare minimum for the first PR. Querying Data is for a later version as we already discussed.

paule96 · 2019-10-07T15:46:59Z

Okay, @DanielHabenicht and @mschwrdtnr, I have e-mailed you the current JSON result of the API, so you can check if you missing something. The result for a dataset of 2000 employees has a response time of 500ms. If this is to slow I must find a way to cache it.

Zeroks77 · 2019-11-28T15:01:32Z

https://stackoverflow.com/questions/807878/how-to-make-javascript-execute-after-page-load/36096571#36096571

DanielHabenicht · 2019-11-28T15:56:28Z

https://stackoverflow.com/questions/807878/how-to-make-javascript-execute-after-page-load/36096571#36096571

Whats that?

paule96 · 2019-12-03T13:13:44Z

https://stackoverflow.com/questions/807878/how-to-make-javascript-execute-after-page-load/36096571#36096571

Whats that?

That is maybe the solution for the out problem. But I'm not shure.

So the idea is to open a new tab or window for the login. If the phonebook is the parent window we can watch in the DOM of this site. And maybe we are able to create an event that is triggered if the login is sucess. But my current plan is an other plan. Maybe we redirect the user always to the login. That is a breaking change to the current phonebook, because currently you can use some features without login. After this you can't. So I think I start with the easy one. So we can start finishing this PR.

azure-pipelines · 2020-04-06T16:20:17Z