Skip to content

#167778960: Fix create trip endpoint #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

#167778960: Fix create trip endpoint #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2265a91
bg(api-create-trip): Fix create trip endpoint
T2Wil Aug 8, 2019
fdfcec0
Update trips.js
T2Wil Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions server/controllers/trips.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,34 @@ import User from '../models/User';
import Trip from '../models/Trip';
import Storage from '../models/Storage';

export const getTrips = (req, res) => {
const user = new User();

//create a trip
export const createTrip = (req, res) => {
const trip = new Trip();
const { decoded } = req;
const { email } = decoded;
const user_exist = user.matchUserByEmail(email);
if (user_exist !== null) {
user.setUser(user_exist);
const trips = user.storage.getTrips();
res.status(200).json({
status: res.statusCode,
message: 'Trips retrieved with success',
data: trips,
const { is_admin } = decoded;
if(is_admin === 'true'){
const newTrip = {
id: req.body.id,
seating_capacity: req.body.seating_capacity,
origin: req.body.origin,
destination: req.body.destination,
trip_date: req.body.trip_date,
fare: req.body.fare,
}
trip.createTrip(newTrip);
res.status(201).json({
status: res.statusCode,
message: 'Trip created with success',
data: trip.getTrip(),
});
} else {
res.status(500).json({
}
else
{
res.status(401).json({
status: res.statusCode,
error: 'internal server error',
error: 'Unauthorized Access',
});
}
};
Expand Down
6 changes: 3 additions & 3 deletions server/routes/trips.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import express from 'express';
import { getTrips, getTrip } from '../controllers/trips';
import { getTrip, createTrip } from '../controllers/trips';
import { verifyToken } from '../helpers/util';

const router = express.Router();

router.post('/', verifyToken, getTrips);
router.post('/', verifyToken, createTrip);
router.get('/:id', verifyToken, getTrip);
export default router;
export default router;