task/WG-703: fix shapefile import failing on NaN values in shapefile properties - #295
Merged
Merged
Conversation
nathanfranklin
requested review from
rstijerina,
shayanaijaz,
sophia-massie and
taoteg
July 18, 2026 00:32
rstijerina
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Fixes shapefile import failures caused by NaN values in DBF fields being serialized as invalid JSON.
Related Jira tickets:
Summary of Changes:
VectorService.process_shapefile, convert NaN/NaT/None values (viapd.isna) toNonewhen building feature properties, so they serialize as valid JSONnullinstead of invalidNaN.Testing Steps:
austin_watershedsin https://www.designsafe-ci.org/data/browser/projects/PRJ-4185/workdir/%2Fshapefile_good%2Faustin_watersheds) and confirm it imports.Notes:
This fixes current work which will be replaced shorting by the work-in-progress #294