Skip to content

Task/WG-321: fix importing for geojson shapefiles - #481

Merged
nathanfranklin merged 9 commits into
mainfrom
task/WG-321-fix-importing-for-geojson-shapefiles
Jul 31, 2026
Merged

Task/WG-321: fix importing for geojson shapefiles#481
nathanfranklin merged 9 commits into
mainfrom
task/WG-321-fix-importing-for-geojson-shapefiles

Conversation

@nathanfranklin

@nathanfranklin nathanfranklin commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Overview:

This PR is frontend changes related to our reworking of importing vector files. See TACC-Cloud/geoapi#294 for all details.

PR Status:

  • Ready.

Related Jira tickets:

@nathanfranklin nathanfranklin changed the title Task/wg 321 fix importing for geojson shapefiles Task/WG-321: fix importing for geojson shapefiles Jul 23, 2026
@nathanfranklin
nathanfranklin requested review from rstijerina, shayanaijaz, sophia-massie and taoteg and removed request for rstijerina July 24, 2026 16:28

@sophia-massie sophia-massie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React build is failing. Nathan and I huddled - found with geoJSON with no metadata, the message "Click a feature on the map to see its attributes." could be confusing because its attributes will not appear after clicking.

Also noticed that the mouse isn't detecting that the pmtiles are clickable even though they are and work correctly i.e. change metadata depending on the point selected.

Otherwise, LGTM!

@nathanfranklin

Copy link
Copy Markdown
Collaborator Author

Also noticed that the mouse isn't detecting that the pmtiles are clickable even though they are and work correctly i.e. change metadata depending on the point selected.

Fixed in a3e0def.

@nathanfranklin
nathanfranklin merged commit deee6ac into main Jul 31, 2026
3 checks passed
@nathanfranklin
nathanfranklin deleted the task/WG-321-fix-importing-for-geojson-shapefiles branch July 31, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants