-
Notifications
You must be signed in to change notification settings - Fork 410
Adding DOSBox as core for DOS TASing #4217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… time to read/understand
Works now without the need for the DOS commands. As a bonus you don't have to install the mouse driver, giving what you'd get with DOSBox-X when running 3.1/3.11.
|
Can you describe exactly what the issue with movie verification is? Have you tried ending the "Preserve hard disk contents" option in the sync settings? |
Oh I see... what's a good way to make that a stand out then? Also just for asking sake-- even though I believe it's not necessary for this system. Cause all it is, is "next floppy disk" which is reminiscent to an issue the Nyma cores had. |
An axis whose range is all floppy indices, should be both easy enough to add and useful enough to be exhaustive for users. Might also consider this for Amiga. The only question is, is such a swapper also relevant for CDs? |
The reason I introduced this option is to prevent Bizhawk from constantly storing the entire hard disk (slow) when in the majority of use cases the users won't need to create verification movies. We'll provide tasvideos-sanctioned verif movies for all the possible windows version anyway.
Implemented for both floppy and cd. Not with an axis but with a prev/next/swap buttons. Swap swaps the current media with the selected one. Soft-eject is not implemented in dosbox as it entails unmounting, which is irreversible (from a BK standpoint). Please test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANKS FOR TREMENDOUS WORK!
I think this is ready for merging, and matters of saveram and weird mouse controls in some games will need to be resolved separately before we mark the core as released.
Lag frame detection cannot be implemented since these machines are IRQ, not polling based
Pending Fixes:
Desirable features for future work (not in this PR):
Test Tools:
Used this to test joystick and mouse support:
https://www.vogons.org/viewtopic.php?p=187168#p187168
Check if completed: