Update wifi.cpp - added faster reflect functions #896
Conversation
I know this is so insignificant because it only hapens on initialization. But maybe future implementation might require it
|
Your replacement functions, reflect8() and reflect32() rearrange the bits on a per-nibble basis, but the original reflect() function rearranges the bits on a per-bit basis. Therefore, these are NOT equivalent functions at all. Nice try trying to optimize, but we've gotta reject this PR because your new functions cannot replace the old function. Optimization is hard. |
|
Okay, might of analyzed this PR too quickly -- the functions actually are equivalent. My bad. Still, at the end of the day, we're just filling a LUT of 256 32-bit values only once at initialization, so this isn't even a performance issue. Meh. Because the functions are, in fact, equivalent, I'll reopen this PR if anyone actually cares. |
|
Yes I know this is not significant at all. I just thought, maybe one day, someone would need to use it in a different place in the code, so he better have a faster implementation... |
I know this is so insignificant because it only hapens on initialization. But maybe future implementation might require it. Feel free to reject it.