Add Pentium and Cyrix models #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -523,6 +523,10 @@ CPU cpus_Slot1_100MHz[] = | |||
| {"Pentium II/350", CPU_PENTIUM_2, fpus_builtin, 20, 350000000, 3, 33333333, 0x651, 0x651, 0, CPU_SUPPORTS_DYNAREC | CPU_REQUIRES_DYNAREC, 18,18,9,9, 42}, | |||
| {"Pentium II/400", CPU_PENTIUM_2, fpus_builtin, 20, 400000000, 3, 33333333, 0x652, 0x652, 0, CPU_SUPPORTS_DYNAREC | CPU_REQUIRES_DYNAREC, 18,18,9,9, 48}, | |||
| {"Pentium II/450", CPU_PENTIUM_2, fpus_builtin, 20, 450000000, 3, 33333333, 0x652, 0x652, 0, CPU_SUPPORTS_DYNAREC | CPU_REQUIRES_DYNAREC, 18,18,9,9, 54}, | |||
| {"Pentium II/550", CPU_PENTIUM_2, fpus_builtin, 20, 550000000, 3, 33333333, 0x652, 0x652, 0, CPU_SUPPORTS_DYNAREC | CPU_REQUIRES_DYNAREC, 18,18,9,9, 70}, | |||
| {"Pentium II/700", CPU_PENTIUM_2, fpus_builtin, 20, 700000000, 3, 33333333, 0x652, 0x652, 0, CPU_SUPPORTS_DYNAREC | CPU_REQUIRES_DYNAREC, 18,18,9,9, 88}, | |||
| {"Pentium II/800", CPU_PENTIUM_2, fpus_builtin, 20, 800000000, 3, 33333333, 0x652, 0x652, 0, CPU_SUPPORTS_DYNAREC | CPU_REQUIRES_DYNAREC, 18,18,9,9, 100}, | |||
There was a problem hiding this comment.
What about some 1.5GHz one too, for cases when that's enough and one wants to avoid maximal slowdown?
There was a problem hiding this comment.
Makes sense, I just PRed the ones that I added while experimenting last year.
Is it a bad idea to have too many CPU options? Do we want to decide which ones to go with?
vadosnaprimer
requested changes
Mar 29, 2025
|
I don't know what the last value in each model (e.g. the 70 here) represents.
I believe I chose rough values based on existing models. It's probably a good idea to confirm what this value is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't feel like building and testing this at the moment, just wanted to get it out there