108 - Add directory listing support #3
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet (label isnt on this repo) |
Derpius
reviewed
May 21, 2025
| @@ -19,6 +19,10 @@ namespace VpkParser { | |||
| const std::function<std::vector<std::byte>(uint16_t archive, uint32_t offset, uint32_t size)>& readFromArchive | |||
| ) const; | |||
|
|
|||
| [[nodiscard]] std::optional<std::pair<std::vector<std::filesystem::path>, std::vector<std::filesystem::path>>> list( | |||
There was a problem hiding this comment.
This should return a struct i think. Not obvious which array is which
| } | ||
|
|
||
| if (fileList.empty() && directoryList.empty()) { | ||
| return std::nullopt; |
There was a problem hiding this comment.
Null should mean "the path you gave me doesnt exist"
This means "the path you gave me either doesnt exist or exists but is empty"
The empty case should return both vectors left empty
| return path == "" || path == "/" || path == "\\"; | ||
| } | ||
|
|
||
| std::filesystem::path normalizePath(std::filesystem::path&& path) { |
There was a problem hiding this comment.
this is worth a doc comment explaining why we have to perform this ourselves
im also surprised that there's no std filesystem method which can check if a given path is contained within another (or there is in which case we should be using that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes