Feat: 유저 Role 조회 API 구현 (#162) - #163
Open
jyjyjy25 wants to merge 1 commit into
Open
Conversation
dionisos198
reviewed
Mar 6, 2024
dionisos198
left a comment
Contributor
There was a problem hiding this comment.
LGTM 입니다.!!
근데 생각해보니까
SuccessHandler 에서
sb.append("http://52.79.200.90:3000/login/oauth2/code")
.append("?")
.append("accessToken=")
.append(accessToken)
.append("&")
.append("refreshToken=")
.append(refreshToken)
.append("&")
.append("userId=")
.append(userId);
이 부분에 Role을 적어서 전달할 수도 있을 것같은데 이에 대해서는 어떻게 생각하시나염? ^^
Member
Author
|
@dionisos198 좋은 방법인 것 같습니다! 그렇게 수정해 볼게요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
🏃 Task
📄 Reference
✅ Check List
mainbranch에 실수로 PR 생성 금지)