Move from role-based to permissions-based checks - #153
Merged
jeremy-rifkin merged 9 commits intoSep 27, 2025
Conversation
michael-kenzel
marked this pull request as draft
May 10, 2025 03:10
michael-kenzel
force-pushed
the
remove-hardcoded-mod-ids
branch
2 times, most recently
from
May 12, 2025 00:56
9f0954a to
cf5d84d
Compare
michael-kenzel
force-pushed
the
remove-hardcoded-mod-ids
branch
from
June 6, 2025 01:01
cf5d84d to
1218800
Compare
|
michael-kenzel
force-pushed
the
remove-hardcoded-mod-ids
branch
from
September 27, 2025 20:14
1218800 to
cfb8e98
Compare
michael-kenzel
changed the title
michael-kenzel
marked this pull request as ready for review
September 27, 2025 20:15
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to do this! One comment on expressiveness (hopefully not too bike-sheddy) and then lgtm
Co-authored-by: Jeremy Rifkin <51220084+jeremy-rifkin@users.noreply.github.com>
michael-kenzel
force-pushed
the
remove-hardcoded-mod-ids
branch
from
September 27, 2025 23:26
164150c to
3615ca6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #141